* [PATCH] thermal: amlogic: Use dev_err_probe() @ 2023-03-24 2:20 ye.xingchen 2023-03-24 10:11 ` Neil Armstrong 2023-03-25 13:09 ` Martin Blumenstingl 0 siblings, 2 replies; 3+ messages in thread From: ye.xingchen @ 2023-03-24 2:20 UTC (permalink / raw) To: glaroque Cc: rafael, daniel.lezcano, amitk, rui.zhang, linux-pm, linux-amlogic, linux-kernel From: Ye Xingchen <ye.xingchen@zte.com.cn> Replace the open-code with dev_err_probe() to simplify the code. Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn> --- drivers/thermal/amlogic_thermal.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c index 4bf36386462f..3abc2dcef408 100644 --- a/drivers/thermal/amlogic_thermal.c +++ b/drivers/thermal/amlogic_thermal.c @@ -262,11 +262,8 @@ static int amlogic_thermal_probe(struct platform_device *pdev) return PTR_ERR(pdata->regmap); pdata->clk = devm_clk_get(dev, NULL); - if (IS_ERR(pdata->clk)) { - if (PTR_ERR(pdata->clk) != -EPROBE_DEFER) - dev_err(dev, "failed to get clock\n"); - return PTR_ERR(pdata->clk); - } + if (IS_ERR(pdata->clk)) + return dev_err_probe(dev, PTR_ERR(pdata->clk), "failed to get clock\n"); pdata->sec_ao_map = syscon_regmap_lookup_by_phandle (pdev->dev.of_node, "amlogic,ao-secure"); -- 2.25.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] thermal: amlogic: Use dev_err_probe() 2023-03-24 2:20 [PATCH] thermal: amlogic: Use dev_err_probe() ye.xingchen @ 2023-03-24 10:11 ` Neil Armstrong 2023-03-25 13:09 ` Martin Blumenstingl 1 sibling, 0 replies; 3+ messages in thread From: Neil Armstrong @ 2023-03-24 10:11 UTC (permalink / raw) To: ye.xingchen, glaroque Cc: rafael, daniel.lezcano, amitk, rui.zhang, linux-pm, linux-amlogic, linux-kernel On 24/03/2023 03:20, ye.xingchen@zte.com.cn wrote: > From: Ye Xingchen <ye.xingchen@zte.com.cn> > > Replace the open-code with dev_err_probe() to simplify the code. > > Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn> > --- > drivers/thermal/amlogic_thermal.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c > index 4bf36386462f..3abc2dcef408 100644 > --- a/drivers/thermal/amlogic_thermal.c > +++ b/drivers/thermal/amlogic_thermal.c > @@ -262,11 +262,8 @@ static int amlogic_thermal_probe(struct platform_device *pdev) > return PTR_ERR(pdata->regmap); > > pdata->clk = devm_clk_get(dev, NULL); > - if (IS_ERR(pdata->clk)) { > - if (PTR_ERR(pdata->clk) != -EPROBE_DEFER) > - dev_err(dev, "failed to get clock\n"); > - return PTR_ERR(pdata->clk); > - } > + if (IS_ERR(pdata->clk)) > + return dev_err_probe(dev, PTR_ERR(pdata->clk), "failed to get clock\n"); > > pdata->sec_ao_map = syscon_regmap_lookup_by_phandle > (pdev->dev.of_node, "amlogic,ao-secure"); Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] thermal: amlogic: Use dev_err_probe() 2023-03-24 2:20 [PATCH] thermal: amlogic: Use dev_err_probe() ye.xingchen 2023-03-24 10:11 ` Neil Armstrong @ 2023-03-25 13:09 ` Martin Blumenstingl 1 sibling, 0 replies; 3+ messages in thread From: Martin Blumenstingl @ 2023-03-25 13:09 UTC (permalink / raw) To: ye.xingchen Cc: glaroque, rafael, daniel.lezcano, amitk, rui.zhang, linux-pm, linux-amlogic, linux-kernel On Fri, Mar 24, 2023 at 3:20 AM <ye.xingchen@zte.com.cn> wrote: > > From: Ye Xingchen <ye.xingchen@zte.com.cn> > > Replace the open-code with dev_err_probe() to simplify the code. > > Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-25 13:09 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-03-24 2:20 [PATCH] thermal: amlogic: Use dev_err_probe() ye.xingchen 2023-03-24 10:11 ` Neil Armstrong 2023-03-25 13:09 ` Martin Blumenstingl
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).
Read more here: Source link